-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix synchronous_mode/synchronous_mode_strict ignored when set to false #2709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@drivebyer
drivebyer
requested review from
FxKu,
Jan-M,
hughcapet,
idanovinda,
jopadi,
macedigital and
sdudoladov
as code owners
July 31, 2024 07:33
PTAL @FxKu
hm - this is contrary to #1223. Always thought omitempty only omits the field when it's not specified, but not on false. But anyway, why is it important to list, when the mode is disabled? With a simple coalesce logic you should be able to check for nil and insert whatever you want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my use case, I import the package from https://github.com/zalando/postgres-operator/tree/master/pkg/apis/acid.zalan.do/v1 into my Golang project. In my project, I use Golang to populate the PostgreSQL resource, and then use client-go to create the resource. However, when updating the PostgreSQL resource, like setting spec.patroni.synchronousMode to false, it gets ignored after marshaling to a string because of the omitempty tag. In my opinion, these fields should not have the omitempty tag.