-
-
Notifications
You must be signed in to change notification settings - Fork 121
Deduplicate logged errors and warnings #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
samdark
merged 4 commits into
yiisoft:master
from
rhertogh:deduplicate_errors_and_warnings
Jun 20, 2023
Merged
Deduplicate logged errors and warnings #293
samdark
merged 4 commits into
yiisoft:master
from
rhertogh:deduplicate_errors_and_warnings
Jun 20, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Summary
- Code refactoring for better maintainability
The code has been restructured to eliminate repeated logic, making it easier to maintain and understand. - Improved error and warning handling
A new hash algorithm is used to ensure that the error and warning arrays are unique, preventing duplicate errors/warnings. - Alphabetical sorting of errors and warnings
Errors and warnings are now sorted alphabetically by file name before being saved to their respective files:errors.txtandwarnings.txt.
...on larger data sets for deduplicating logged errors and warnings
Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same error or warning might be logged multiple times. This PR deduplicate them before writing them to their respective files.