Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added feature of viewing method source code without external links #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samdark merged 10 commits into yiisoft:master from arogachev:147-method-source-code
Dec 2, 2021
Merged

Added feature of viewing method source code without external links #232

samdark merged 10 commits into yiisoft:master from arogachev:147-method-source-code
Dec 2, 2021

Conversation

@arogachev
Copy link
Contributor

@arogachev arogachev commented Nov 30, 2021

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues #147

Peek 2021年11月30日 13-23

@arogachev arogachev requested a review from a team November 30, 2021 07:33
@arogachev arogachev self-assigned this Nov 30, 2021

$lines = file($this->sourceFile);
for($i = $this->startLine - 1; $i <= $this->endLine - 1; $i++) {
$this->sourceCode .= substr($lines[$i], 4);
Copy link
Contributor Author

@arogachev arogachev Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 can be calculated dynamically. 🤔

bizley reacted with thumbs up emoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "4" exactly?

Copy link
Member

@samdark samdark Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Number of spaces.

arogachev reacted with thumbs up emoji
Copy link
Contributor Author

@arogachev arogachev Dec 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's the number of spaces we need to remove from the beginning of each line. I thought of existence of cases with different amount of spaces used for indentation, tabs instead of spaces and so on. But we discussed it with @samdark and decided to leave it as is now.

@samdark samdark added the status:code review The pull request needs review. label Dec 1, 2021
@samdark samdark merged commit ab99a07 into yiisoft:master Dec 2, 2021
@arogachev arogachev deleted the 147-method-source-code branch December 2, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samdark samdark samdark left review comments

@bizley bizley bizley left review comments

Labels

status:code review The pull request needs review. type:enhancement Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /