Search code, repositories, users, issues, pull requests...

Copy link

Contributor

@rylxes rylxes commented Jul 5, 2018 •

edited

Loading

you can just add the columns you do not want to be exported using

protected $excludeFromExport = ['column_name'];

in the model's Datatable


 implemented the 'exclude column from export' where you can just add t...

8a00861

...he columns you don't want to be exported

@yajra yajra changed the title ~~(削除) implemented the 'exclude column from export' (削除ここまで)~~ (追記) [3.0] Implemented the 'exclude column from export' (追記ここまで)

@yajra

Copy link

Owner

yajra commented Jul 6, 2018

Can you please remove the .idea files that were added.

yajra

yajra requested changes

src/Services/DataTable.php

$orientation = config('datatables-buttons.snappy.orientation');

$snappy->setOptions($options)

->setOrientation($orientation);

Copy link

Owner

@yajra yajra Jul 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this indention.

src/Services/DataTable.php

->setOrientation($orientation);

return $snappy->loadHTML($this->printPreview())

->download($this->getFilename() . '.pdf');

Copy link

Owner

@yajra yajra Jul 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this indention.

sherriff added 3 commits

July 6, 2018 02:41


 remove .idea files

19b6e61


 reverted back indentation

99784cb

removed unwanted idea file


 Merge branch 'excluded-columns' of https://github.com/rylxes/laravel-...

f6c67ce

...datatables-buttons into excluded-columns

Copy link

Contributor Author

rylxes commented Jul 6, 2018

made the changes as requested

yajra

yajra approved these changes

@yajra yajra added the enhancement label

yajra

yajra requested changes

Copy link

Owner

@yajra yajra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the excess new line to fix the failing StyleCI. Thanks!

src/Services/DataTable.php Outdated

protected $dataTableVariable = 'dataTable';

Copy link

Owner

@yajra yajra Jul 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the excess new line.

src/Services/DataTable.php Outdated

return is_array($this->printColumns) ? $this->printColumns : $this->getFilteredColumnsFromBuilder();

}

Copy link

Owner

@yajra yajra Jul 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the excess new line.

src/Services/DataTable.php

return $this->html()->removeColumn(...$this->excludeFromExport)->getColumns();

}

Copy link

Owner

@yajra yajra Jul 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the excess new line.

@rylxes @StyleCIBot


 Apply fixes from StyleCI

422c602

yajra

yajra approved these changes

@yajra

Copy link

Owner

yajra commented Jul 6, 2018

Just wondering, since we only aim to exclude from export, I think we should not touch the print columns or better, create a separate handler for it? What do you think?

Copy link

Contributor Author

rylxes commented Jul 6, 2018

i think creating a separate handler for it would be nicer

sherriff and others added 2 commits

July 6, 2018 11:31


 separated the $excludeFromExport and $excludeFromPrint

4a4c4b1

@rylxes @StyleCIBot


 Apply fixes from StyleCI

84d5f2a

yajra

yajra requested changes

Jul 7, 2018

Copy link

Owner

@yajra yajra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little typo and I think this is good to go. Thanks!

src/Services/DataTable.php Outdated

}

/**

* Get filtered print columns definition from html builder.

Copy link

Owner

@yajra yajra Jul 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get filtered export columns definition from html builder.


 text change

d9f4c5b

Copy link

Contributor Author

rylxes commented Jul 10, 2018

Done

yajra

yajra approved these changes

Aug 15, 2018