-
-
Notifications
You must be signed in to change notification settings - Fork 56
Adding dataTableVariable property to Services/DataTables #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Services/DataTable.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a period.
Looks good. Just need some patch on docs. Thanks!
I've corrected the typo.
For the docs, i don't know where to put it, in buttons-starter.md ?
Thanks, maybe we should add a new doc file to document service class properties? There are also undocumented properties like exportColumns, printColumns, printPreview, etc..
yes i think we need a new documentation file for the properties and methods of the service class
Uh oh!
There was an error while loading. Please reload this page.
Hello,
i'm adding dataTableVariable property to Services/DataTables.
The default value is dataTable like before, but can be overwritten by setting the dataTableVariable property in our custom dataTable class :
Thanks.