-
-
Notifications
You must be signed in to change notification settings - Fork 56
Fix model namespace for Laravel 8.x. #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yajra
merged 2 commits into
yajra:4.0
from
luckys383:create_model_to_models_dir_if_exists
Oct 31, 2020
Merged
Fix model namespace for Laravel 8.x. #117
yajra
merged 2 commits into
yajra:4.0
from
luckys383:create_model_to_models_dir_if_exists
Oct 31, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...els directory in namespace for model
@yajra could you please review this PR and provide your feedback?
@yajra
yajra
added
hacktoberfest
hacktoberfest-accepted
Accepted for Hacktoberfest
labels
Oct 22, 2020
@yajra
yajra
changed the title
(削除) added support for Laravel 8.x if Models directory exists then use Mod... (削除ここまで)
(追記) Added support for Laravel 8.x if Models directory exists. (追記ここまで)
Oct 22, 2020
PR Looks good, will try to check on actual project as soon as I can. Thanks!
@yajra
yajra
changed the title
(削除) Added support for Laravel 8.x if Models directory exists. (削除ここまで)
(追記) Fix model namespace for Laravel 8.x. (追記ここまで)
Oct 31, 2020
Released on v4.10.1 🚀 Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for Laravel 8.x if Models directory exists then use Models directory in namespace for model
PR for the issue Pointing to wrong model path when generating DataTable - Laravel 8