-
Notifications
You must be signed in to change notification settings - Fork 2
feat(test): add playwright configuration, add e2e tests, improve esli... #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jzolnowski
jzolnowski
commented
Feb 3, 2023
- add playwright configuration
- add e2e tests
- improve eslint configuration
@gkalpak PR ready for another round of review
@gkalpak PR ready for another round of review
@gkalpak PR ready for the final review
@gkalpak
gkalpak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :shipit:
Splaktar
commented
Mar 16, 2023
Is it possible to update this repo and the .nvmrc file to NodeJS 18? Right now, it's set to NodeJS 14, but the last commit on master updated the package-lock.json file to v3. If we're going to do that, we should probably update the NodeJS version too.
Is it possible to update this repo and the
.nvmrcfile to NodeJS 18? Right now, it's set to NodeJS 14, but the last commit on master updated the package-lock.json file to v3. If we're going to do that, we should probably update the NodeJS version too.
I set the engine-strict flag in .npmrc. I updated the npm and node versions in the package.json engines: npm v9, node>=18. I tested if the package installation, start and testing of the application works correctly. Everything looks fine
Comments have been addressed.
@jzolnowski, can you please make sure all commits are signed 🙏
...ation file, fix Redirect to Angular Material page test
...otrodLogo alt attribute to an empty string due it's decorative
...e to above or equal 18
7d98905 to
f85ec1d
Compare
...ng @babel/core dev dependency
@jzolnowski, can you please make sure all commits are signed 🙏
All commits signed 🎉
image
