-
Notifications
You must be signed in to change notification settings - Fork 2
chore(package.json): update angular.js to v1.9.3 along with other non-angularjs related dependencies #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@gkalpak
gkalpak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also update the lockfile.
aeb1fa4 to
eb81c89
Compare
@gkalpak
gkalpak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR now contains more updates than just "angular.js to v1.9.2".
We should either limit the changes to AngularJS or update the commit message to reflect the actual changes.
eb81c89 to
86b7dad
Compare
@gkalpak
gkalpak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes lgtm, but I find the commit message confusing/unclear. What does "angular.js-based libraries" refer to?
The changes lgtm, but I find the commit message confusing/unclear. What does "angular.js-based libraries" refer to?
angular.js-based librarie means all the rest bumped angularjs-based packages like:
"angular-animate": "npm:@xlts.dev/angular-animate@^1.9.2",
"angular-aria": "npm:@xlts.dev/angular-aria@^1.9.2",
"angular-material": "npm:@xlts.dev/angular-material@^1.2.4",
"angular-messages": "npm:@xlts.dev/angular-messages@^1.9.2"
@gkalpak
gkalpak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes lgtm, but I find the commit message confusing/unclear. What does "angular.js-based libraries" refer to?
angular.js-based librarie means all the rest bumped angularjs-based packages like:
"angular-animate": "npm:@xlts.dev/angular-animate@^1.9.2", "angular-aria": "npm:@xlts.dev/angular-aria@^1.9.2", "angular-material": "npm:@xlts.dev/angular-material@^1.2.4", "angular-messages": "npm:@xlts.dev/angular-messages@^1.9.2"
I see. I don't think we need to explicitly mention these libraries in the commit message, since they are part of the AngularJS framework and can be collectively referred to as AngularJS.
But this PR also updates other non-AngularJS related dependencies. We should either mention that in the commit message to move those other updates to a separate commit/PR.
86b7dad to
1ba8516
Compare
@gkalpak
gkalpak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should now update to v1.9.3 😉
...-angularjs related dependencies After executing `npm install`, `package-lock.json` was also updated to reflect the changes from `package.json`. In the process of updating the lockfile, several versions of the dependencies were upgraded automatically.
1ba8516 to
832ca7c
Compare
We should now update to v1.9.3 😉
Done
Uh oh!
There was an error while loading. Please reload this page.
After executing
npm install,package-lock.jsonwas also updated to reflect the changes frompackage.json.In the process of updating the lockfile, several versions of the dependencies were upgraded automatically.