-
Notifications
You must be signed in to change notification settings - Fork 2
Parametrize over different reduction operations #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parametrize over different reduction operations #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of "min" or "max" would be good for checking that dtype is preserved. I'm not sure "std" adds much over "var".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were really just chosen in order to cover some known bugs with cubed. Specifically that cubed doesn't yet implement std or var, and the array API standard only requires mean to work with floats, not integers.
Eventually we would want a test suite that covers everything, this is just meant to be a proof-of-principle for discussing overall design.
No description provided.