This repository was archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 57
Use the new yaml for Android X #196
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@foreach (var dep in @Model.NuGetDependencies) {
if (!dep.IsProjectReference) {
<PackageReference Include="@(dep.NuGetPackageId)" Version="@(dep.NuGetVersion)" />
<PackageReference Include="@(dep.NuGetPackageId)" Version="@(dep.NuGetVersion)" PrivateAssets="none"/>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to make sure that the .nupkg will correctly import the dependencies - such as Guava.
@mattleibow
mattleibow
changed the title
(削除) Use the new yaml (削除ここまで)
(追記) [WIP] Use the new yaml (追記ここまで)
Aug 28, 2019
@mattleibow
mattleibow
changed the title
(削除) [WIP] Use the new yaml (削除ここまで)
(追記) [WIP] Use the new yaml for Android X (追記ここまで)
Aug 28, 2019
...nents into dev/new-yaml # Conflicts: # azure-pipelines.yml
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
@mattleibow
mattleibow
changed the title
(削除) [WIP] Use the new yaml for Android X (削除ここまで)
(追記) Use the new yaml for Android X (追記ここまで)
Sep 19, 2019
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
Redth
Redth
reviewed
Oct 1, 2019
<attr path="/api/package[@name='androidx.slice.widget']/class[@name='LargeSliceAdapter']/method[@name='onBindViewHolder' and count(parameter)=2 and parameter[1][@type='androidx.slice.widget.LargeSliceAdapter.SliceViewHolder'] and parameter[2][@type='int']]/parameter[1]" name="type">androidx.recyclerview.widget.RecyclerView.ViewHolder</attr>
<attr path="/api/package[@name='androidx.slice.widget']/class[@name='SliceView']/method[@name='onChanged' and count(parameter)=1 and parameter[1][@type='androidx.slice.Slice']]/parameter[1]" name="managedType">Java.Lang.Object</attr>
<attr path="/api/package[@name='androidx.slice.widget']/interface[@name='SliceActionView.SliceActionLoadingListener']" name="visibility">public</attr>
<remove-node path="/api/package[@name='androidx.slice.widget']/interface[@name='SliceActionView.SliceActionLoadingListener']" />
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to double check this change?
Redth
Redth
approved these changes
Oct 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR needs a few others to be merged first: