Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Tooling] Fail on Version Mismatch Between ReleasesV2 and Project #24963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iangmaia wants to merge 1 commit into trunk
base: trunk
Choose a base branch
Loading
from iangmaia/fail-when-code-freeze-version-mismatch

Conversation

@iangmaia
Copy link
Contributor

@iangmaia iangmaia commented Oct 30, 2025
edited
Loading

See AINFRA-1478

Description

This PR enhances the version validation added in the previous iteration to fail the build when there's a mismatch between the ReleasesV2 version and the project's computed version.

Previous behavior: Version mismatches showed a warning but allowed the build to continue.

New behavior: Version mismatches now fail the build with a clear error message, ensuring alignment between ReleasesV2 and the project before proceeding.

Changes

  • Changed version mismatch handling from warning to error
  • Build now fails with UI.user_error! when versions don't match
  • Updated Buildkite annotation from warning to error style

Testing

This will be tested in the next release cycle during code freeze.

@iangmaia iangmaia self-assigned this Oct 31, 2025
@iangmaia iangmaia added this to the 26.5 milestone Oct 31, 2025
@iangmaia iangmaia added the Tooling Build, Release, and Validation Tools label Oct 31, 2025
@iangmaia iangmaia force-pushed the iangmaia/fail-when-code-freeze-version-mismatch branch from f49417e to 7eb63f5 Compare October 31, 2025 22:22
@iangmaia iangmaia marked this pull request as ready for review October 31, 2025 22:22
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AliSoftware AliSoftware Awaiting requested review from AliSoftware

@mokagio mokagio Awaiting requested review from mokagio

At least 1 approving review is required to merge this pull request.

Labels

Tooling Build, Release, and Validation Tools

Projects

None yet

Milestone

26.5

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /