-
Notifications
You must be signed in to change notification settings - Fork 82
Auth API #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Auth API #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
really nice work! Though for some reason your push 33 commits and I cannot merge it.
Can you try rebasing? also do not bump versions, I will do it.
thanks
@karrirasinmaki
karrirasinmaki
changed the base branch from
develop
to
master
February 9, 2018 21:30
Thanks! I think I created my branch originally from master. Changed the PR base branch according.
Oh, and couple things to note/ask:
- In API class files (eq. src/Users.ts) there were interface code written. However, the same interface was defined in interfaces.ts, so I decided to import those interfaces from there and wrote those in a single place only. Was there some purpose of writing the same code in multiple places?
- Updated angular libraries in package.json from ^4.0.0 to ^4.4.6. Might not be necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working with WP authentication and implementing it into this library.
I've been testing this in my own projects for a while now. Still, some work needs to be done before actually merging this into distribution.
Needs to be done: