-
Couldn't load subscription status.
- Fork 15
Add SourceLink support to package #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
30cfc99 to
b2258ce
Compare
@weichch Are you still maintaining this package? Happy to take it over if not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @matracey Thanks again for taking effort to contribute. Like I mentioned in the comments, can we please track the repository house-keeping changes in a separate issue?
It's a little hard to follow the actual changes in this PR with more than 100 files changed due to reformatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why moved solution file here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it makes more sense to have the sln file at the root, since the src folder will contain the source for the library itself, and the test folder will contain the source code for the tests.
IMO, it's easier to find the sln file in the root, since many open source .NET repos follow this paradigm, and it makes more sense to reference like src\SystemTextJson.JsonDiffPatch\SystemTextJson.JsonDiffPatch.csproj & test\SystemTextJson.JsonDiffPatch.UnitTests\SystemTextJson.JsonDiffPatch.UnitTests.csproj rather than SystemTextJson.JsonDiffPatch\SystemTextJson.JsonDiffPatch.csproj & ..\test\SystemTextJson.JsonDiffPatch.UnitTests\SystemTextJson.JsonDiffPatch.UnitTests.csproj.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of adding this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added SourceLink because it provides a great source debugging experience for end users. It provides a lot of debug-time assistance, allowing to step into the source code of the compiled NuGet package by pulling the source from GitHub, rather than trying to use decompilation. SourceLink is supported by Microsoft and included in the .NET SDK for a variety of common source control providers, including GitHub, and adding it provides a quick win for a much improved package consumer experience.
I cherry picked some of the changes in this PR into #43 as co-authored commit. Let's keep this PR open for addressing VS Code support if you wish.
I also found Microsoft has added two new methods in .NET 8 JsonNode.DeepEquals and JsonNode.DeepClone. Those methods are conflicting with the extension methods in this package as per mentioned in #4, and I will take a look at how to address those. Meanwhile, those methods don't seem to exist in .NET 6 and .NET 7.
e03d069 to
e72126c
Compare
e72126c to
9f29013
Compare
Uh oh!
There was an error while loading. Please reload this page.
New features and updates
522be95add debug symbols and explicit packable configuration tosrc/Directory.build.propsf1fd5d7add explicitSourceLink.GitHubpackage reference31bd648add msbuild properties forSourceLinke72126cupgrade packages to latest versionsProject structure enhancements
558b8cbmoveslnfile up to project rootf616e41add missing loose items toslnfilef4ef2d5add recommended VS Code extensions toextensions.json8cecd49updategitignoreusingdotnet new gitignore7b1e292addglobal.jsonwith SDK version configurationd554044addIsTestProjectproperty toDirectory.Build.propsfor test folder5ea3667updateAssemblyVersionandFileVersionto useJsonDiffPatchPackageVersion