-
-
Notifications
You must be signed in to change notification settings - Fork 440
Don't send receiver reports for SSRC during simulcast probe #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't send receiver reports for SSRC during simulcast probe #623
Conversation
dfd2697 to
ead8d6d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #623 +/- ## ======================================= Coverage 60.63% 60.63% ======================================= Files 471 471 Lines 48430 48465 +35 Branches 12280 12291 +11 ======================================= + Hits 29365 29389 +24 Misses 9676 9676 - Partials 9389 9400 +11 ☔ View full report in Codecov by Sentry. |
Any updates on this? I'm happy to make changes if there are other ideas on how to propagate the probe status into the interceptor!
5402eaf to
ffead9f
Compare
libwebrtc will stop sending SDES headers after the first receiver report on a SSRC. This breaks probing if the receiver report is sent before probing is completed. This change delays receiver reports for a SSRC until the first non-probe packet is received.
ead8d6d to
2decea1
Compare
463d5f6 to
a1f8f19
Compare
libwebrtc will stop sending SDES headers after the first receiver report on an SSRC1 . This breaks simulcast probing if the receiver report is sent before probing is completed. This change delays receiver reports for probing SSRCs until the first non-probe packet is received.
I didn't find any easy way to get this information into the interceptor, so I opted for using attributes. Let me know if you prefer some other means.
Footnotes
https://github.com/webrtc-sdk/webrtc/blob/0ae5688d4d490274ea47fee3f87f622ef3f13113/modules/rtp_rtcp/source/rtp_sender.cc#L509 ↩