Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[interceptor] control max packet age for NACK responses #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
k0nserv wants to merge 3 commits into master
base: master
Choose a base branch
Loading
from add-nack-responder-max-packet-age

Conversation

@k0nserv
Copy link
Member

@k0nserv k0nserv commented Oct 7, 2022 •
edited
Loading

TODO:

  • Tests

@k0nserv k0nserv force-pushed the add-nack-responder-max-packet-age branch from 5612d59 to 8c869b4 Compare October 11, 2022 12:42
@k0nserv k0nserv force-pushed the add-nack-responder-max-packet-age branch from e22f3a4 to 5572970 Compare November 10, 2022 11:08
@k0nserv k0nserv marked this pull request as ready for review November 10, 2022 11:08
Copy link

codecov bot commented Nov 10, 2022 •
edited
Loading

Codecov Report

Base: 59.87% // Head: 59.87% // No change to project coverage 👍

Coverage data is based on head (3e47da6) compared to base (3e47da6).
Patch has no changes to coverable lines.

❗ Current head 3e47da6 differs from pull request most recent head 5302015. Consider uploading reports for the commit 5302015 to get more accurate results

Additional details and impacted files 
@@ Coverage Diff @@
## master #313 +/- ##
=======================================
 Coverage 59.87% 59.87% 
=======================================
 Files 503 503 
 Lines 47644 47644 
 Branches 12357 12357 
=======================================
 Hits 28528 28528 
 Misses 9889 9889 
 Partials 9227 9227

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


/// Assert that a RTP packet has traversed interceptor chains.
///
/// Like [`writte_rtp`] but does not wait.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Like [`writte_rtp`] but does not wait.
/// Like [`written_rtp`] but does not wait.

@melekes melekes changed the title (削除) Control max packet age for NACK responses (削除ここまで) (追記) [interceptor] control max packet age for NACK responses (追記ここまで) Nov 22, 2022
@k0nserv k0nserv force-pushed the add-nack-responder-max-packet-age branch from 5572970 to 5302015 Compare November 28, 2022 11:06
Copy link

@k0nserv any plan on merging this any time soon? I think we're also hitting the edge case of retransmissions aggravating the problem

Copy link

I also wonder how receivers handle the case where certain nacks are ignored. E.g. I've seen Chrome sending the same nack over and over.

Copy link
Contributor

melekes commented Jun 19, 2023

@k0nserv anything left to do here except (a) rebase (b) fix conflicts ? thanks 🙏

Copy link
Member Author

k0nserv commented Jun 19, 2023

I don't believe so
melekes and ris-work reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@melekes melekes melekes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /