-
-
Notifications
You must be signed in to change notification settings - Fork 11
Remove redundant title attributes from configuration code blocks in Tab components #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLAassistant
commented
Sep 4, 2025
CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
✅ Deploy Preview for rstest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: fi3ework <12322740+fi3ework@users.noreply.github.com>
...on code blocks Co-authored-by: fi3ework <12322740+fi3ework@users.noreply.github.com>
title="rstest.config.ts to missing code blocks in website/docs. remember must modify zh and en files together. (削除ここまで)@copilot re-check are the files updated in docs/en identical with docs/zh?
@copilot re-check are the files updated in
docs/enidentical withdocs/zh?
No, the files updated in docs/en are not identical to docs/zh. I found at least one significant difference:
reporters.mdx (line 134):
- EN:
reporters: [['junit', { outputPath: './junit.xml' }]] - ZH:
reporters: ['junit']
The English version shows the full configuration example with outputPath, while the Chinese version shows a simplified example. Both have the title="rstest.config.ts" attribute correctly added, but the configuration content differs.
The text content is properly translated between languages, but some code examples appear to have intentional differences in complexity/completeness.
@copilot do not add the title when it's wrapped in a Tab that already declares the file name, like below
<Tab label="rstest.config.ts"> ```ts title="rstest.config.ts"
...nts that already declare filename Co-authored-by: fi3ework <12322740+fi3ework@users.noreply.github.com>
@copilot do not add the title when it's wrapped in a
Tabthat already declares the file name, like below
...
I've removed the redundant title="rstest.config.ts" attributes from all code blocks that are inside <Tab label="rstest.config.ts"> components. The Tab label already declares the filename, making the title attribute redundant.
Changes made:
- Processed 41 documentation files (20 English + 21 Chinese)
- Only removed titles from code blocks inside Tab components that declare "rstest.config.ts"
- Preserved title attributes for standalone code blocks that are not wrapped in tabs
Fixed in commit 0c1d791.
Uh oh!
There was an error while loading. Please reload this page.
This PR fixes redundant
title="rstest.config.ts"attributes in code blocks that are already wrapped in<Tab label="rstest.config.ts">components across the documentation.Problem
Many configuration code blocks were wrapped in Tab components that already declared the filename in their label attribute, making the additional
title="rstest.config.ts"attribute redundant and visually cluttered:Solution
Removed the redundant
title="rstest.config.ts"attributes from code blocks that are inside<Tab label="rstest.config.ts">components, while preserving title attributes for standalone code blocks that are not wrapped in tabs.Files Changed
website/docs/{zh,en}/config/test/Example Change
This change eliminates visual redundancy while maintaining clear documentation structure - the Tab label already indicates the filename, so the title attribute is unnecessary.
💬 Share your feedback on Copilot coding agent for the chance to win a 200ドル gift card! Click here to start the survey.