Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add E2E tests for examples 1-4 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mornir merged 11 commits into wearelucid:master from mornir:master
Dec 22, 2019
Merged

Add E2E tests for examples 1-4 #2

mornir merged 11 commits into wearelucid:master from mornir:master
Dec 22, 2019

Conversation

@mornir
Copy link
Contributor

@mornir mornir commented Aug 11, 2019

I am currently learning how to use Cypress and I thought that this repository would be a great place to experiment 😁

I can add more tests later, but it might make less sense because Cypress can't check if an email has been sent or a notification was posted on Slack.

Next step is to add continuous integration. For this, I really want to try GitHub actions 😃
https://github.blog/2019-08-08-github-actions-now-supports-ci-cd/

@mornir mornir requested a review from marcoeh August 11, 2019 18:05
Copy link
Member

marcoeh commented Aug 15, 2019
edited
Loading

Hey @mornir, thanks for the PR! You might want to check out #4 which solves your #3. As soon as we merged #4 you probably have to check this PR again to make sure everything works as expected.

@mornir mornir merged commit 4e1b778 into wearelucid:master Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcoeh marcoeh Awaiting requested review from marcoeh

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /