-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[breaking/do not merge] es(1403): improve middleware extension hooks configuration types #7372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lsliwaradioluz
wants to merge
6
commits into
main
from
es-1403/improve-middleware-extension-hooks-configuration-types
Open
[breaking/do not merge] es(1403): improve middleware extension hooks configuration types #7372
lsliwaradioluz
wants to merge
6
commits into
main
from
es-1403/improve-middleware-extension-hooks-configuration-types
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3db4445 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@lsliwaradioluz
lsliwaradioluz
changed the title
(削除) es(1403): improve middleware extension hooks configuration types (削除ここまで)
(追記) [breaking/do not merge] es(1403): improve middleware extension hooks configuration types (追記ここまで)
Jan 16, 2025
@lsliwaradioluz
lsliwaradioluz
requested a review
from a team
as a code owner
January 16, 2025 14:03
Quality Gate Passed Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
fumeoss
commented
Feb 20, 2025
Summary
- Introduces breaking changes to the
@vue-storefront/middlewarepackage regarding middleware extension hooks configuration types. - Updates the type of the
hooksproperty in theApiClientExtensioninterface to ensure proper typing of the hooks'configurationparameter. - Changes the return type of the
createMultistoreExtensionhelper toApiClientExtension. - Both changes require consumers of the middleware to update if they are using version
4.1.2or lower.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
ES-1403