Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat($default-theme): Support Azure Repos url for page edition (Closes #1959) #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chryw wants to merge 3 commits into vuejs:master
base: master
Choose a base branch
Loading
from chryw:feature/azure-repos-edit-link

Conversation

@chryw
Copy link

@chryw chryw commented Oct 16, 2019 •
edited
Loading

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
fixes #1959

@chryw chryw changed the title (削除) Fix #1959 (削除ここまで) (追記) Fix Support Azure Repos url in "PageEdit.vue" #1959 (追記ここまで) Oct 16, 2019
@chryw chryw changed the title (削除) Fix Support Azure Repos url in "PageEdit.vue" #1959 (削除ここまで) (追記) feat: Support Azure Repos url in "PageEdit.vue" #1959 (追記ここまで) Oct 16, 2019
@chryw chryw changed the title (削除) feat: Support Azure Repos url in "PageEdit.vue" #1959 (削除ここまで) (追記) feat: #1959 (追記ここまで) Oct 16, 2019
@chryw chryw changed the title (削除) feat: #1959 (削除ここまで) (追記) Fixes #1959 (追記ここまで) Oct 16, 2019
@chryw chryw changed the title (削除) Fixes #1959 (削除ここまで) (追記) Fixes #1959 - Support Azure Repos url in "PageEdit.vue" (追記ここまで) Oct 16, 2019
@chryw chryw changed the title (削除) Fixes #1959 - Support Azure Repos url in "PageEdit.vue" (削除ここまで) (追記) Fix #1959 - Support Azure Repos url in "PageEdit.vue" (追記ここまで) Oct 16, 2019
@chryw chryw changed the title (削除) Fix #1959 - Support Azure Repos url in "PageEdit.vue" (削除ここまで) (追記) feat: Support Azure Repos url in "PageEdit.vue" #1959 (追記ここまで) Oct 16, 2019
Copy link
Collaborator

@chryw Thanks for your contribution. Could you update the doc to let users know that azure repositories are also supported?
chryw reacted with thumbs up emoji

@kefranabg kefranabg changed the title (削除) feat: Support Azure Repos url in "PageEdit.vue" #1959 (削除ここまで) (追記) feat($default-theme): Support Azure Repos url for page edition (Closes #1959) (追記ここまで) Oct 28, 2019
Copy link
Author

chryw commented Nov 6, 2019

@kefranabg I added docs. Please take a look and feel free to reword anything. Hopefully this can be merged soon ^_^ it will enable more non-developers in our team to make quick edits for individual pages. Thanks a lot!

Copy link
Collaborator

@kefranabg kefranabg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @chryw

Copy link
Author

chryw commented Jan 3, 2020

@kefranabg hello~ do you know when this will be available in the official release? Thanks!

Copy link

Can this please be made available in the public version? Would be really handy and works like a charm (merged it manually in my own version now).

I have one added suggestion.
Change line: "+ &version=GBmaster" to + &version=GB + docsBranch

This way the branch in the settings file is also taken into account.
image

Copy link
Member

ulivz commented Dec 20, 2021

Could you address the conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kefranabg kefranabg kefranabg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Azure Repos url in "PageEdit.vue"

AltStyle によって変換されたページ (->オリジナル) /