-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
Fix handling v-if along with v-for on a template tag #2663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/fragment/factory.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could be simpler, since v-for and v-if are the only ones that can work on <template>, and v-for has higher priority than v-if, it seems v-if is the only thing that we need to check.
paulpflug
commented
Apr 13, 2016
I'm unsure if this relates: while working on #2619, I noticed, that v-for is evaluated before slot, besides the priority says otherwise.
Could have the same origin? (although it is handy to have v-for before slot)
@paulpflug are you talking about something like <slot v-for="...">? I don't think it's related, no.
paulpflug
commented
Apr 13, 2016
@simplesmiler fine. It just attracted my attention that in both cases priorities don't work (the way I understand them 😄)
@paulpflug this one has to do with the fact that <template> loses all attributes when being turned into a fragment factory 😉
Proposed fix for #2657