Search code, repositories, users, issues, pull requests...

Copy link

Member

@gebilaoxiong gebilaoxiong commented Jan 20, 2016

您好。

您的代码非常精彩,分而治之的道理无处不在,以至于在第二遍阅读的时候任然感觉荡气回肠。

另外有个小问题:

在解析v-这种一般指令的时候为什么不用正则将指令名称和参数分离呢。

[画像:yyx990803]

yyx990803 reviewed

Jan 20, 2016

View reviewed changes

src/compiler/compile.js Outdated

Copy link

Member

@yyx990803 yyx990803 Jan 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attribute name 不可能有 = 号啊,为啥要避开 = 号

Copy link

Member

yyx990803 commented Jan 20, 2016

这里的代码是 1.0 时候逐步重构过来的,所以顺着那时候的思路就变这样了。用一个正则确实更简洁一些。多谢!

Copy link

Member

yyx990803 commented Jan 20, 2016

另外还请最终合并成一个 commit

Copy link

Member Author

gebilaoxiong commented Jan 21, 2016

终于回滚正常了,抱歉,git用得不是很熟悉,给你添麻烦了。我马上修改下

@gebilaoxiong gebilaoxiong closed this

Copy link

Member

yyx990803 commented Jan 21, 2016

你可以 git reset 到最后一个不属于你的 commit,然后重新 commit。之后 git push -f 到你的 fork 即可

@gebilaoxiong gebilaoxiong reopened this

Copy link

Member Author

gebilaoxiong commented Jan 21, 2016

好的我试试


 modify:指令优化解析

c4391b8

@gebilaoxiong gebilaoxiong force-pushed the dev branch from 65578e5 to c4391b8 Compare

January 21, 2016 03:39

Copy link

Member Author

gebilaoxiong commented Jan 21, 2016

感谢。受教了。麻烦您抽空看看

yyx990803 added a commit that referenced this pull request


 Merge pull request #2196 from gebilaoxiong/dev

6002ed2

指令解析优化

@yyx990803 yyx990803 merged commit 6002ed2 into vuejs:dev