-
-
Couldn't load subscription status.
- Fork 33.8k
fix: convert emits to props, fix #13104 #13105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'll take a look and add tests
I need some help, I couldn't get emits from extends and mixin work...
This fix is beyond my capabilities and I hope someone else can fix it.
zcf0508
commented
Dec 15, 2023
No, your implementation doesn't take extends and mixin into account
No, your implementation doesn't take
extendsandmixininto account
Yes, you are right, I'm working on it. But now I have some questions. I see you add a test that you can get emit functions fromprops in setup function, but the props does not expose those functions. It is a right type test?
Yes, because it can be undefined
zcf0508
commented
Dec 18, 2023
Does it mean that If a component use props.onFoo in runtime, the function will never work? Is the onFoo only used for type inference?
Yes, seemed to be true
Uh oh!
There was an error while loading. Please reload this page.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
mainbranch for v2.x (or to a previous version branch)fix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Converts emits to props.
Other information: