-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
Feat/show important directive #12942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding support for important modifier on v-show directive
Did you see this idea was already rejected at #3761 ?
@posva Yes, I read that issue, but I think this is relevant, because I have met with this problem many times, and other devs faced this too.
I think it's not big deal to implement it, another library did it
@posva Also, if we implement a custom directive to display none important, this new one doesn't trigger the transition classes (if it's wrapped by a transition component), keep in mind
@posva any news from this PR?
Adding support for
importantmodifier onv-showdirectiveDoes this PR introduce a breaking change?
The PR fulfills these requirements:
mainbranch for v2.x (or to a previous version branch)fix #xxx[,#xxx], where "xxx" is the issue number)The explanation to include this feature is when you have a component (from an external library or own component) and this component has a display flex (or other display property on CSS), the v-show directive doesn't work showing the content you are trying to hide/show. You can make a workaround, like switching the class with the condition used into the directive, but it could be easier for developers only add this modifier