-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
fix(types): deny unknown attributes by default #12794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
blake-newman
wants to merge
1
commit into
vuejs:main
from
Attest:blake.newman/deny-unknown-attributes-by-default
Closed
fix(types): deny unknown attributes by default #12794
blake-newman
wants to merge
1
commit into
vuejs:main
from
Attest:blake.newman/deny-unknown-attributes-by-default
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@blake-newman
blake-newman
changed the title
(削除) Blake.newman/deny unknown attributes by default (削除ここまで)
(追記) fix(types): deny unknown attributes by default (追記ここまで)
Sep 20, 2022
Deny unknown attributes by default; using type for `ReservedProps` gave a default index signature which allowed uknown attributes. Import expectType in tsx type test as this was causing false error suppression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deny unknown attributes by default; using type for
ReservedPropsgave a default index signature which allowed uknown attributes.Import
expectTypein tsx type test as this was causing false error suppression.What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
Screenshot from 2022年09月20日 11-02-12
I'm unsure why
[name: string]: stringindex type is being applied when usingtypebut using interface fixes it 🤷. I can't get this to apply in TS playground 😮💨