Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

chore: move to typescript #12001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pikax wants to merge 58 commits into vuejs:dev from pikax:move_to_typescript
Closed

chore: move to typescript #12001

pikax wants to merge 58 commits into vuejs:dev from pikax:move_to_typescript

Conversation

@pikax
Copy link
Member

@pikax pikax commented Apr 3, 2021 •
edited
Loading

What kind of change does this PR introduce? (check at least one)

  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: Typescript code base

Does this PR introduce a breaking change? (check one)

  • No

Other information:

Move the code base from flow to typescript

Plan

This PR plans to convert the current flow code into typescript and type some of the code, avoiding changes to javascript output code.

This PR will stay open for a while, there's many pending PR which need to be merged before this.

Status

  • convert all the js files to typescript
  • replace flow types with typescript
  • make build and CI work
  • introduce typing to plain JS files

redblue9771, shooterRao, iola1999, wruiwrui, Wxh16144, knightgao, goldEli, SCWR, lonfger, wangweiguo2013, and 166 more reacted with thumbs up emoji kiaking, jacekkarczmarczyk, zhixiangyao, nrgnrg, CyberAP, danielroe, scottbedard, Kocal, Donskelle, Niputi, and 55 more reacted with hooray emoji cllemon, Xaber20110202, ifzm, Mikchail, wuliupo, SvenZhao, zhiyue-yi, watonyweng, fanioc, ShineKidd, and 8 more reacted with heart emoji HcySunYang, posva, kiaking, sqal, zhixiangyao, danielroe, croumegous, scottbedard, fi3ework, Niputi, and 45 more reacted with rocket emoji kiaking, aykxt, Barbapapazes, zigomir, Dante-dan, BiYuqi, redblue9771, 0es, Otto-J, Wxh16144, and 16 more reacted with eyes emoji
@pikax pikax self-assigned this Apr 3, 2021
@pikax pikax marked this pull request as ready for review April 7, 2021 13:55
Copy link

wyx1818 commented Apr 12, 2021

膜拜大佬

Copy link

xiaohuahegege commented Apr 13, 2021 •
edited
Loading

6666, Dai lo ! 😄 niubility.
Xaber20110202, wujun4code, hezhongfeng, Caleb-Xu, wyx2014, bnyu, NuoHui, h0twind, WishinZhang, zhiyue-yi, and 12 more reacted with thumbs up emoji fi3ework reacted with thumbs down emoji Xaber20110202, wujun4code, vegawong, and qiu9yu reacted with laugh emoji Xaber20110202, wujun4code, wrpota, Deeplycovered-leaf, zhiyue-yi, wangxdmm, and vegawong reacted with hooray emoji Xaber20110202, wujun4code, and vegawong reacted with heart emoji Xaber20110202, wujun4code, nilRoot, zhiyue-yi, and arginsen reacted with rocket emoji Xaber20110202, wujun4code, and vegawong reacted with eyes emoji

Copy link

神

Copy link
Contributor

amazing PR

dwelch2344 and others added 12 commits May 3, 2022 11:04
Copy link

holy god!
vuthanhbayit and dajpes reacted with thumbs up emoji

yyx990803 added 15 commits May 20, 2022 07:29
Copy link
Member

To avoid merge issues w/ dev, I created a new main branch which is based on this PR - thanks a lot for the heroic work!
pikax, Justineo, YiStick, LinusBorg, mrcego, liulinboyi, oceangravity, dinhquochan, deweyou, jeremio, and 12 more reacted with hooray emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@KaelWD KaelWD KaelWD left review comments

@iceman201 iceman201 iceman201 approved these changes

Reviewers whose approvals may not affect merge requirements

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /