Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix(v-on): add removing all dom event listeners when vnode destroyed #10085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
posva merged 1 commit into vuejs:dev from zrh122:remove-dom-listeners
Aug 5, 2021

Conversation

@zrh122
Copy link
Contributor

@zrh122 zrh122 commented May 29, 2019 •
edited by posva
Loading

Add removing all dom event listeners when vnode destroyed
fixes #10083
fixes #10004

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

ygj6, ota-meshi, piotrek-horodenski, and zongzi531 reacted with thumbs up emoji zongzi531 reacted with laugh emoji zongzi531 reacted with rocket emoji
Copy link

clopezcapo commented Jul 1, 2019 •
edited
Loading

Do you know if this also happens in the PROD version? As I am not able to filter by "vue" components in Chrome DevTools. I see the same code as the dev version though...
f2009 and songguangyu reacted with eyes emoji

Copy link

Hi all,
I can confirm this fixes the memory leak problem in our app. We have some quite large Vue components so this issue is actually crashing our app after typing inside inputs and reopening some modal windows for example.
Is this planned to be released?
Thanks a lot :)
Donskelle, chencmgithub, suneab, songguangyu, LoveSlience, SijieCai, harryjubb, and JhonWeawer reacted with thumbs up emoji

Copy link

momodiy commented Jul 20, 2020

I'm sure this is useful
novakjcn, suneab, songguangyu, SijieCai, geekqc, lidaining-web, JhonWeawer, and pear1958 reacted with thumbs up emoji

Copy link

suneab commented Oct 7, 2020

Is this planned for release? We are still patching this in our solution
novakjcn, songguangyu, SijieCai, and lidaining-web reacted with thumbs up emoji

Copy link

@posva, could you please let us know by when this fix would be made available?
novakjcn, suneab, songguangyu, SijieCai, and lidaining-web reacted with thumbs up emoji

Copy link

@posva same facing this problem, when this fix would be made available?
songguangyu, tashuobutianhei, miller, litokele2018, SijieCai, and lidaining-web reacted with thumbs up emoji

Copy link

I have waited for this pr and patch fix for a long time, could somebody merge or give some explanation if there are other concern or risk for the pending.
tashuobutianhei, miller, litokele2018, aka434112, SijieCai, suneab, sqladmin-zz, MarMun, Stormiks, and lidaining-web reacted with thumbs up emoji miller, aka434112, songguangyu, suneab, and lidaining-web reacted with rocket emoji

Copy link

any update for this PR?

Copy link

suneab commented Nov 24, 2020

Still waiting :)

can-keklik added a commit to can-keklik/countly-server that referenced this pull request Feb 10, 2021
Copy link
Member

ygj6 commented Aug 5, 2021

Hi @posva, my team also encountered this problem. And I have tested this patch, it works!

Copy link

When will it be released?
lidaining-web reacted with thumbs up emoji

Copy link

Can anyone tell me when this fix will be released?and why so long? 🙂
hosnar, bashess, Stormiks, lidaining-web, g3tl0st, whity, kdydesign, marvinrabe, mae-financial-com, boy-liutao, and DeiviA reacted with thumbs up emoji

Copy link

kdydesign commented Apr 4, 2022 •
edited
Loading

Has it been released? 2.6.15 Please let me know the release schedule.
lidaining-web and lykiao reacted with thumbs up emoji

Copy link

leealso commented Sep 2, 2022

Anything on this one?

Copy link

when is the release expected?
suneab and zhengzhibo reacted with laugh emoji

Copy link

Is this available if we use the ^2.7.0 version or in which version to find this fix?

Copy link

I would like to know when 2.6.15 will be released

Copy link

Awesome!!! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@posva posva posva approved these changes

+1 more reviewer

@ygj6 ygj6 ygj6 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug about keep-alive and @click.native caused repeated attach event handler? Memory leak with component with input with v-model

AltStyle によって変換されたページ (->オリジナル) /