Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

🐛Fix: incorrect indentation in vue/script-indent rule #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalsnik merged 4 commits into vuejs:master from ota-meshi:fix-script-indent
Sep 28, 2018

Conversation

@ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Jun 23, 2018

fixed #441,#443

gluons reacted with thumbs up emoji
Copy link

👍

Copy link
Member

@michalsnik michalsnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one comment

const token = tokens[i]
const offsetInfo = offsets.get(token)

// If the first token is not trivial then ignore trivial following tokens.
Copy link
Member

@michalsnik michalsnik Sep 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this comment is not relevant anymore

Copy link

@euclid1990 euclid1990 Sep 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michalsnik I have a question, If this PR is merged, how can I install latest eslint-plugin-vue with fixed code ?

Copy link
Member Author

@michalsnik Thank you for pointing out.
I chenged it, so please check again.

Copy link

Hi!
Any news on this?
Thank you for your work! 😉

Copy link
Member

Alright, let's give it a spin while we're still in beta and the rule is still uncategorized.

mghignet reacted with thumbs up emoji

@michalsnik michalsnik merged commit 82d939c into vuejs:master Sep 28, 2018
@ota-meshi ota-meshi deleted the fix-script-indent branch November 13, 2018 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mysticatea mysticatea Awaiting requested review from mysticatea

2 more reviewers

@euclid1990 euclid1990 euclid1990 left review comments

@michalsnik michalsnik michalsnik approved these changes

Reviewers whose approvals may not affect merge requirements

Projects

None yet

Milestone

v5.0.0

Development

Successfully merging this pull request may close these issues.

Script-Indent rule inconsistences

AltStyle によって変換されたページ (->オリジナル) /