Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

🐛Fix: v-bind order in vue/attribute-order rule #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalsnik merged 7 commits into vuejs:master from ydfzgyj:v-bind
Jul 24, 2018

Conversation

@ydfzgyj
Copy link
Contributor

@ydfzgyj ydfzgyj commented Mar 6, 2018 •
edited
Loading

close #410 , close #422

d3radicated and hoopyfroody reacted with thumbs up emoji
ex: 'v-model'
- OTHER_ATTR
ex: 'customProp="foo"'
ex: 'custom-prop="foo"', 'v-bind:prop="foo"', ':prop="foo"', 'v-custom-directive'
Copy link
Member

@michalsnik michalsnik Mar 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should mix other attributes with bindings.
Let's keep both groups: TWO_WAY_BINDINGS and BINDINGS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a common situation that when user needs to change a static property value to a dynamic binding value. If we separate them into two groups, the user may have to modify the order of these properties and feel confused. Maybe it's still better to let user themselves to sort these attributes.

Copy link
Contributor Author

ydfzgyj commented Mar 22, 2018

Only solved the conflict but did not change anything else

Copy link
Contributor

@chrisvfritz chrisvfritz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! 🙂 I only noticed one small typo that I commented on.

## :book: Rule Details

This rule aims to enforce ordering of component attributes. The default order is specified in the [Vue styleguide](https://vuejs.org/v2/style-guide/#Element-attribute-order-recommended) and is:
This rule aims to enfore ordering of component attributes. The default order is specified in the [Vue styleguide](https://vuejs.org/v2/style-guide/#Element-attribute-order-recommended) and is:
Copy link
Contributor

@chrisvfritz chrisvfritz Mar 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a typo here.

ydfzgyj reacted with thumbs up emoji
@michalsnik michalsnik added this to the v5.0.0 milestone Mar 24, 2018
@michalsnik michalsnik changed the title (削除) Fix: v-bind order in vue/attribute-order rule (削除ここまで) (追記) 🐛Fix: v-bind order in vue/attribute-order rule (追記ここまで) Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@chrisvfritz chrisvfritz chrisvfritz approved these changes

@michalsnik michalsnik michalsnik approved these changes

Reviewers whose approvals may not affect merge requirements

Projects

None yet

Milestone

v5.0.0

Development

Successfully merging this pull request may close these issues.

vue/attributes-order: v-dom-portal errors if placed after v-if v-bind attribute should be sorted by its real name

AltStyle によって変換されたページ (->オリジナル) /