-
Notifications
You must be signed in to change notification settings - Fork 4.9k
docs(reactivity-watchers.md): remove ambiguous "versions before 3.5" statement from watcher onCleanup section #3302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...statement from watcher onCleanup section Removed the ambiguous line "This works in versions before 3.5. In addition". The onCleanup callback argument remains available in 3.5+, so the old note could mislead readers into thinking it was deprecated; dropping it keeps the wording accurate and concise.
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
Removed the ambiguous line "This works in versions before 3.5. In addition".
The onCleanup callback argument remains available in 3.5+, so the old note could mislead readers into thinking it was deprecated; dropping it keeps the wording accurate and concise.
Proposed Solution
Remove the misleading sentence. No other changes to code examples or surrounding explanations are needed.
Additional Information
none