-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
feat: implement defineVaporCustomElement #14017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
+2,908
−227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Important
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
✨ Finishing touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
- Commit unit tests in branch
edison/feat/defineVaporCustomElement
Comment @coderabbitai help to get the list of available commands and usage tips.
Size ReportBundles
Usages
|
@vue/compiler-core
npm i https://pkg.pr.new/@vue/compiler-core@14017
@vue/compiler-dom
npm i https://pkg.pr.new/@vue/compiler-dom@14017
@vue/compiler-sfc
npm i https://pkg.pr.new/@vue/compiler-sfc@14017
@vue/compiler-ssr
npm i https://pkg.pr.new/@vue/compiler-ssr@14017
@vue/compiler-vapor
npm i https://pkg.pr.new/@vue/compiler-vapor@14017
@vue/reactivity
npm i https://pkg.pr.new/@vue/reactivity@14017
@vue/runtime-core
npm i https://pkg.pr.new/@vue/runtime-core@14017
@vue/runtime-dom
npm i https://pkg.pr.new/@vue/runtime-dom@14017
@vue/runtime-vapor
npm i https://pkg.pr.new/@vue/runtime-vapor@14017
@vue/server-renderer
npm i https://pkg.pr.new/@vue/server-renderer@14017
@vue/shared
npm i https://pkg.pr.new/@vue/shared@14017
vue
npm i https://pkg.pr.new/vue@14017
@vue/compat
npm i https://pkg.pr.new/@vue/compat@14017
commit: 8a298fa
@edison1105
edison1105
force-pushed
the
edison/feat/defineVaporCustomElement
branch
from
October 24, 2025 03:55
a819eeb to
e808152
Compare
the template helper cannot resolve them properly they require creation via createElement
...t has been torn down
❌ Deploy Preview for vue-sfc-playground failed. Why did it fail? →
|
@edison1105
edison1105
force-pushed
the
edison/feat/defineVaporCustomElement
branch
from
October 29, 2025 02:09
c423a43 to
642e253
Compare
...n useHost function
@edison1105
edison1105
force-pushed
the
edison/feat/defineVaporCustomElement
branch
from
October 29, 2025 02:15
642e253 to
9b5e134
Compare
defineSSRCustomElement can only be used with custom elements that have pre-rendered declarative shadow root
await assertInteraction('my-element-async')
})
test('work with Teleport (shadowRoot: false)', async () => {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defineSSRCustomElement can only be used with custom elements that have pre-rendered declarative shadow root. It requires shadowRoot: true.
@edison1105
edison1105
added
✨ feature request
New feature or request
version: minor
scope: vapor
related to vapor mode
labels
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.