Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add LVideoOverlay #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mandryllo wants to merge 9 commits into vue-leaflet:master
base: master
Choose a base branch
Loading
from mandryllo:video-overlay
Open

Conversation

@mandryllo
Copy link
Contributor

@mandryllo mandryllo commented Jul 21, 2021
edited
Loading

This PR adds LVideoOverlay component (link)

Depends on #685

Copy link
Contributor

mikeu commented Jul 27, 2021

@mandryllo thanks again for these contributions! I know that there are currently no tests for the LImageOverlay component that you are extending here, but it would be great if you could add some tests both here and in #684 for the new code and components at least. If you had time to backfill the tests for LImageOverlay as well then that would be fantastic, even if it only covered the url prop that's been moved around.

Copy link
Contributor Author

@mikeu I will add them, probably sometime next week 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /