-
Notifications
You must be signed in to change notification settings - Fork 182
Add guard to render chapter slider just once. #1586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@derekkraan
derekkraan
force-pushed
the
main
branch
from
February 18, 2025 10:50
a5cebf2 to
34d9fdc
Compare
@derekkraan
derekkraan
force-pushed
the
main
branch
from
March 17, 2025 09:47
34d9fdc to
2515e51
Compare
This was referenced Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Related:
Should fix #1191. Or at least provide a template for fixing further issues described in #1191.
Related PRs: #1616 #1617
Description:
Adds a guard to ensure that the chapter slider only renders once, even when onConnect is called multiple times.
Ready?
Yes.
Anything Else?
Solves this issue with the double chapter slider:
image
See this thread on SO for some background information.
Review Process:
Trigger calling onConnect twice. See the linked SO issue above. Or see @bu6n's issue repository linked in #1191 to reproduce. But I hope it is relatively straightforward to see what is going on here.