-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore: refactor version bump script for improved readability and maintainability #3021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ayoub-Mabrouk
wants to merge
1
commit into
vercel:main
from
Ayoub-Mabrouk:chore/refactor-version-bump-script
Open
chore: refactor version bump script for improved readability and maintainability #3021
Ayoub-Mabrouk
wants to merge
1
commit into
vercel:main
from
Ayoub-Mabrouk:chore/refactor-version-bump-script
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Ayoub-Mabrouk
Ayoub-Mabrouk
requested review from
huozhi and
shuding
as code owners
September 15, 2024 18:55
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
eshimischi
commented
Dec 14, 2024
You don't need semicolons in JS/TS code anymore, why?
Won't the destructuring of ,process.env, be a problem for those that use DefinePlugin from webpack? Typically the process.env.FOO is inlined as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the version bump script to enhance its readability and maintainability. The following changes have been made:
bumpVersionfunction to use a more concise approach for logging or executing the command.updateVersionfunction with improved logic and readability.These improvements aim to make the script easier to understand and modify in the future.