-
Notifications
You must be signed in to change notification settings - Fork 29
Update Frame to allow use of React.Fragment #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
readme.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we can pass a React component to React.createElement so that <Keyframes component={React.Fragment}> just work. Maybe we should make it clear on README.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should support a "Fragment" string too. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! I didn't realize that. I updated the docs.
Also, I don't think we need to? I removed it from my code because doing <Keyframes component={React.Fragment}> seems to be sufficient. What do you think?
Uh oh!
There was an error while loading. Please reload this page.
Intro
Hi there!
First, thank you for creating this 🙏 I was looking for an easy way to animate using React components.
Problem
I wanted to be able to use <React.Fragment /> as the rendered component so that the components inside of
Framecould be rendered without a wrapper essentially.My hope is to use this to animate parts of an SVG component in React.
Solution
Inside
frame.jscheck ifcomponent === 'Fragment', if so, render inside<React.Fragment />I tested this in a Codesandbox and it seems to be working: https://codesandbox.io/s/5309430n5x
Notes
This is my first OSS PR that is not related to docs so please be kind in any feedback you have 😄 Happy to make changes based on any feedback! Not sure if this is the best way to approach the problem but thought I'd submit the PR and listen to any feedback you have.
PS...I didn't write any tests but we probably should. I wasn't sure exactly what to test. If you have advice there, also open to it.