-
Notifications
You must be signed in to change notification settings - Fork 1
feature: accessible difference data with callback #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also this commit enables passing custom differ in case of need And now exporting type DiffResult and Differ class
✅ Deploy Preview for virtual-react-json-diff ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @utkuakyuz, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the extensibility and control over the diffing process within the VirtualizedDiffViewer component. It provides a new mechanism for consumers to access the underlying diff data and allows for the injection of custom diffing algorithms. These changes empower developers to tailor the diff viewing experience to their specific needs and integrate more deeply with the diff results.
Highlights
- Accessible Diff Data: Introduced a new
getDiffDatacallback prop to theVirtualizedDiffViewercomponent, allowing external components to receive the raw diff results (left and rightDiffResult[]arrays) whenever the diff data changes. This enables more advanced external processing or display of the diff information. - Custom Differ Support: Added a
customDifferprop toVirtualizedDiffViewerProps, enabling users to provide their own instance of theDifferclass. This offers greater flexibility by allowing custom diffing logic to be injected into the viewer. - Exported Types and Classes: The
Differclass andDiffResulttype fromjson-diff-kitare now exported from the main library entry point. This makes them easily accessible for consumers who wish to implement custom diffing or work with thegetDiffDatacallback.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new feature to access the raw difference data via a getDiffData callback and allows for passing a custom differ instance. This enhances the flexibility of the component. The implementation is mostly solid, using a ref to handle the callback and memoization to control updates. However, I've found a critical issue in the new fastHash function used to detect changes in the diff data. The current hashing logic can lead to collisions and prevent the callback from firing when it should. I've provided a suggestion for a more robust hashing algorithm. The other changes, like exporting Differ and DiffResult, are great additions for library consumers.
resolves #21
Version 1.0.13 published
Also this commit enables passing custom differ in case of need
And now exporting type DiffResult and Differ class