-
Notifications
You must be signed in to change notification settings - Fork 66
Fix count for redis_egress sg rule #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IrmantasMarozas
wants to merge
1
commit into
umotif-public:main
from
IrmantasMarozas:feature/fix-egress-rule
Open
Fix count for redis_egress sg rule #42
IrmantasMarozas
wants to merge
1
commit into
umotif-public:main
from
IrmantasMarozas:feature/fix-egress-rule
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Ohid25
Ohid25
added
bug
Something isn't working
question
Further information is requested
labels
Aug 15, 2023
Has this been validated using one of the examples?
I tried running this change against one of the examples and I got
❯ terraform validate
╷
│ Error: Incorrect attribute value type
│
│ on ../../main.tf line 142, in resource "aws_security_group_rule" "redis_egress":
│ 142: cidr_blocks = var.egress_cidr_blocks[count.index]
│ ├────────────────
│ │ count.index is a number
│ │ var.egress_cidr_blocks is a list of string
│
│ Inappropriate value for attribute "cidr_blocks": list of string required.
Second, I'm not totally sure what the issue is here in the first place. What is this solution trying to solve?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
Fix count for redis_egress sg rule
I'm not sure why, but pre-commit hook for docs didn't work for me, so I commented it out.
Terraform docs...........................................................Failed