-
Couldn't load subscription status.
- Fork 143
Add extra flags #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra flags #340
Conversation
Hi @filipopo,
Thank you for the optimization work - reducing the image from 2.58GB to 2.06GB is impressive!
Unfortunately, I need to close this PR because:
- It has merge conflicts
- This repository prioritizes simplicity for beginners over performance optimizations
As a proof-of-concept repository, I want to keep the Dockerfile minimal and immediately understandable for first-time users, even if it means larger image sizes. The optimization flags (--nodocs, --setopt=install_weak_deps=0, etc.) add complexity that might confuse newcomers.
Your PR is still valuable as it documents these optimizations for anyone who needs production-level performance!
Thanks for all your contributions to the project! 🙏
Uh oh!
There was an error while loading. Please reload this page.
These are some changes that reduce the image size and make the build faster
dnf:
--nodocs doesn't install documentation files, can be be checked with e.g rpm -qd unzip
Using install_weak_deps=0 installs about 110 less packages, can be checked with dnf install
clean all will remove package install cache, I also added in a rm -rf for the "best practices"
pip:
--no-cache-dir kinda self-explanatory
-U will upgrade the package if there's a new release
Overall the difference in the image size is 2.58GB without, versus 2.06GB with the new flags
I also corrected this
=> WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)Of course I ran a basic test to make sure that it still works