-
Notifications
You must be signed in to change notification settings - Fork 49
Update for Angular v14 #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 12, 2022
@wawyed can we try to run the ci on this?
Hmmm are you use you did this correctly? I don't see any package.json changes
good point... I though followed the steps in that doc from the other repo, but I think you're right that something went wrong..
I have run npx ng update @angular/core @angular/cli and it looks better with more changes to commit:
The installed Angular CLI version is outdated.
Installing a temporary Angular CLI versioned 14.2.2 to perform the update.
✔ Package successfully installed.
DEPRECATED: The 'defaultProject' workspace option has been deprecated. The project to use will be determined from the current working directory.
Using package manager: yarn
Collecting installed dependencies...
Found 27 dependencies.
Fetching dependency metadata from registry...
Updating package.json with dependency @angular-devkit/build-angular @ "14.2.2" (was "13.3.9")...
Updating package.json with dependency @angular/animations @ "14.2.1" (was "13.0.2")...
Updating package.json with dependency @angular/cli @ "14.2.2" (was "13.3.9")...
Updating package.json with dependency @angular/compiler-cli @ "14.2.1" (was "13.0.2")...
Updating package.json with dependency typescript @ "4.8.3" (was "4.4.4")...
Updating package.json with dependency @angular/common @ "14.2.1" (was "13.0.2")...
Updating package.json with dependency @angular/compiler @ "14.2.1" (was "13.0.2")...
Updating package.json with dependency @angular/core @ "14.2.1" (was "13.0.2")...
Updating package.json with dependency @angular/forms @ "14.2.1" (was "13.0.2")...
Updating package.json with dependency @angular/platform-browser @ "14.2.1" (was "13.0.2")...
Updating package.json with dependency @angular/platform-browser-dynamic @ "14.2.1" (was "13.0.2")...
UPDATE package.json (1793 bytes)
✔ Packages successfully installed.
** Executing migrations of package '@angular/cli' **
❯ Remove 'defaultProject' option from workspace configuration.
The project to use will be determined from the current working directory.
UPDATE angular.json (3360 bytes)
Migration completed.
❯ Remove 'showCircularDependencies' option from browser and server builders.
Migration completed.
❯ Replace 'defaultCollection' option in workspace configuration with 'schematicCollections'.
Migration completed.
❯ Update Angular packages 'dependencies' and 'devDependencies' version prefix to '^' instead of '~'.
✔ Packages installed successfully.
Migration completed.
❯ Remove 'package.json' files from library projects secondary entrypoints.
Migration completed.
❯ Update TypeScript compilation target to 'ES2020'.
UPDATE src/tsconfig.json (502 bytes)
Migration completed.
** Executing migrations of package '@angular/core' **
❯ As of Angular version 13, `entryComponents` are no longer necessary.
UPDATE src/app/global/global.module.ts (516 bytes)
Migration completed.
❯ In Angular version 14, the `pathMatch` property of `Routes` was updated to be a strict union of the two valid options: `'full'|'prefix'`.
`Routes` and `Route` variables need an explicit type so TypeScript does not infer the property as the looser `string`.
Migration completed.
❯ As of Angular version 14, Forms model classes accept a type parameter, and existing usages must be opted out to preserve backwards-compatibility.
Migration completed.
Merged
@wawyed can we:
- merge Fix Mergify #772 , then
- run the CI on this commit + verify it looks good to you
- (TEST) merge this PR by applying
ready to squash and mergelabel - run CI on ui-router/angular PR: Update Dependencies to Angular v14 angular#967
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: ui-router/angular#967
Found these instructions for updating Angular versions in: https://github.com/ui-router/angular/blob/master/add_support_for_new_angular_version.txt so I am creating PR after running the following steps: