Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: update package.json to include TS declarations in ESM exports #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UzEE wants to merge 3 commits into twilio:main
base: main
Choose a base branch
Loading
from UzEE:fix-esm-types-export

Conversation

@UzEE
Copy link

@UzEE UzEE commented Sep 20, 2025
edited
Loading

Problem

After #1130, consumers using TypeScript with moduleResolution: node16/nodenext/bundler get
TS7016 ... implicitly has an 'any' type ... could not be resolved when respecting package.json "exports" when importing twilio.

Cause

Type declarations aren’t exported via package.json "exports", so TS refuses to load them when respecting exports (discussion here).

Fixes

Add a "types" condition to the "." export so TypeScript can resolve ./index.d.ts while Node keeps using the JS entry points. TS docs describe this mechanism and recommend putting "types" first in the condition list.

Runtime impact

None. Node ignores "types". make test passes locally.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

TheForsakenSpirit reacted with thumbs up emoji
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /