-
Notifications
You must be signed in to change notification settings - Fork 64
TECHEMPROD-1428 - Fix broken reference to TwilioClientOptions #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Starting Twilio NodeJS SDK version 4.0.0, the reference for TwilioClientOptions was removed. I included the right option: RequestClientOptions to fix the TS compiling process.
⚠️ No Changeset found
Latest commit: 5d044e5
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Hi @dcanonmolina,
Thanks for submitting this fix for the TwilioClientOptions type issue.
I wanted to bring my related PR #541 to your attention, which addresses this same issue as part of a broader upgrade to Twilio SDK v5.
In Twilio SDK v5, the primary options type for the client constructor appears to be ClientOpts. My PR #541 updates the dependencies and types accordingly, using ClientOpts directly. To help with compatibility where the old name might still be referenced, it also includes an export ClientOpts as TwilioClientOptions.
Based on the changes in v5, ClientOpts seems to be the intended type rather than RequestClientOptions.
Could the maintainers perhaps review PR #541 first? Merging it should resolve the underlying type issue that this PR (#542) aims to fix, potentially making this one redundant.
Happy to discuss further!
@mikefaille thanks! I'm going to withdraw my PR in favor of yours.
Starting Twilio NodeJS SDK version 4.0.0, the reference for TwilioClientOptions was removed. I included the right option: RequestClientOptions to fix the TS compiling process.
Contributing to Twilio