Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat(twilio-run): upgrading serverless-runtime-types #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewbenington wants to merge 3 commits into twilio-labs:main
base: main
Choose a base branch
Loading
from andrewbenington:main

Conversation

@andrewbenington
Copy link

@andrewbenington andrewbenington commented Feb 28, 2023

  • Upgraded serverless-runtime-types in the twilio-run package
  • Fixed typing errors that arose from using the new version
    • Added cookies attribute to Response class, as well as setCookie and removeCookie functions in order to fully implement the TwilioResponse interface
    • in the constructContext function of routes.ts, I had to explicitly include the SERVICE_SID and ENVIRONMENT_SID attributes of env due to env being typed as any
    • I had to specify ServerlessEventObject as the type parameter for an invocation of constructContext

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Andrew Benington added 2 commits February 28, 2023 12:11 
fixed typing issues that arose from using the upgraded package
Cookies are stored with a value and optional list of attributes
Copy link

changeset-bot bot commented Feb 28, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: ad52bb6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
twilio-run Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@andrewbenington andrewbenington changed the title (削除) Upgrading serverless-runtime-types for twilio-run (削除ここまで) (追記) feat(twilio-run): upgrading serverless-runtime-types for twilio-run (追記ここまで) Feb 28, 2023
@andrewbenington andrewbenington changed the title (削除) feat(twilio-run): upgrading serverless-runtime-types for twilio-run (削除ここまで) (追記) feat(twilio-run): upgrading serverless-runtime-types (追記ここまで) Feb 28, 2023
Copy link

Hi @andrewbenington, thank you for submitting a PR to the serverless toolkit. At this time, it's unlikely we will be able to merge feature PRs for at least the near future. I'd like to keep this open since it's a good start at a needed improvement, but there are some things that would need to be addressed before merging this when the time comes.

Thanks again for taking the time to contribute a PR and apologies that we cannot move forward at present!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /