-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
Adding of a method that get the successor of a node inside the birany search tree #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #589 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 153 154 +1 Lines 2645 2649 +4 Branches 438 439 +1 ========================================= + Hits 2645 2649 +4
Continue to review full report at Codecov.
|
How can I complete my checks ?, I remark that I need to do the continuous integration but how can I do it ?
Thanks
lazarljubenovic
commented
Dec 13, 2020
To be honest, this looks more like basic logarithm operations for a math class and less like a CS algorithm for this repo. Maybe if the code found the first 1 in the binary representation and cleared bits on the right?
For you I should not use the logarithm operation ? because this looks more like the math class ?
lazarljubenovic
commented
Dec 13, 2020
I'm not commenting on the code itself, I'm commenting on its inclusion in the project which has the usual bunch of CS algorithms. Calculating the "next power of two" is just applying the well-known logarithm function. In my opinion, it doesn't fit here. But I'm not the maintainer, just giving my two cents.
Ok. I understand that you say. But I wanted to do it because I have another contribution for this repository and which use it, then I have seen better to separate it.
This is my first pull request. I am a beginner, I would like to learn about git GitHub and JavaScript.
...ch tree data structure
...e some value inside the function successor for getting the successor of a node
I have added one file to your repository, this file contains a function which take a number and returns the power of two which is directly greater than the given number. I have also added a test file and a README file.