-
-
Couldn't load subscription status.
- Fork 30.9k
fix(graph): return ordered cycle path and add early exit in detectUndirectedCycle #2080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
punit1009
wants to merge
5
commits into
trekhleb:master
from
punit1009:fix/detect-undirected-cycle-#2057
Open
fix(graph): return ordered cycle path and add early exit in detectUndirectedCycle #2080
punit1009
wants to merge
5
commits into
trekhleb:master
from
punit1009:fix/detect-undirected-cycle-#2057
+66
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@asanpardazzagros-debug
asanpardazzagros-debug
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please confirm whether this workflow will be approved?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes issue #2057 .
The
detectUndirectedCyclefunction previously returned a vertex-to-parent mapping which was unintuitive and difficult to consume. This PR changes the function to return an ordered array of vertices forming the cycle (e.g.[A, B, C, A]), with the first and last elements equal to clearly indicate the cycle closure.Changes
Checklist
npm run lintpasses (or auto-fixed)npm testpassesFixes #123