install pcov for 7.1 - 7.4 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

krakjoe wants to merge 2 commits into travis-ci:default

from krakjoe:pcov

Open

install pcov for 7.1 - 7.4 #30

krakjoe wants to merge 2 commits into travis-ci:default from krakjoe:pcov

Conversation

@krakjoe

Copy link

@krakjoe krakjoe commented Feb 8, 2019

This installs pcov (a new code coverage driver) for 7.1 through 7.4, it is disabled by default so it doesn't interfere with jobs requiring Xdebug for coverage.

krakjoe added 2 commits

February 8, 2019 15:03

@krakjoe


 install pcov for 7.1 - 7.4

67e9f65

@krakjoe


 .travis.yml

1c1713a

krakjoe

krakjoe commented

Feb 9, 2019

View reviewed changes

bin/compile

xdebug.max_nesting_level = 256

EOF

cat >> "${INSTALL_DEST}/${VERSION}/etc/conf.d/pcov.ini" <<EOF

Copy link

Author

@krakjoe krakjoe Feb 9, 2019 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right to me with fresh eyes this morning, this wants to be written after the extension is installed, but I'm not sure what is the best way to do that within travis... maybe just write this line into the global ini ?