-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Enhancement: Discord Added for Social links and footer and use react-icons instead #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@nijamaDev is attempting to deploy a commit to the Saasify Team on Vercel.
A member of the Team first needs to authorize it.
GitMac32
commented
Mar 24, 2023
this code is full of garbage bloat & security concerns.
Restricting EsLint from proper checks
Intentionally setting a security policy restricting script sources
checking for runtime env in gitactions...
I could go on here, but I don't have to.
transitive -bullshit is right. shame on you all
this code is full of garbage bloat & security concerns.
Restricting EsLint from proper checks Intentionally setting a security policy restricting script sources checking for runtime env in gitactions...
I could go on here, but I don't have to.
transitive -bullshit is right. shame on you all
Excuse me? What are you talking about?
I think you might be in the wrong PR. I just added a way of setting up discord to the social links and on the footer and updated the react icons
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎
This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.
Thanks @nijamaDev. This PR looks great. Sorry I don't have time to maintain this project properly and I really have no idea what the other user was talking about.
I'm going through and doing a bunch of updates at the moment, so will consider these changes in a bit.
0f860a4 to
6bcb13b
Compare
282bf7c to
6a43cd1
Compare
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
6a43cd1 to
4c4a505
Compare
- replaced @react-icons/all files with react-icons - use react icons instead of pure svg for the social links - Added Discord to the social links and footer correct imports
4c4a505 to
738cc5e
Compare
Made a simple change so the icons in the social links use react-icons instead of having the pure svg defined in the file, also changed the icons import in the footer to have cleaner and more consistent code.
List of changes: