Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Changes in github workflow #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomato42 merged 1 commit into tlsfuzzer:master from gstarovo:ubuntu20-deprecation
Sep 8, 2025

Conversation

@gstarovo
Copy link
Contributor

@gstarovo gstarovo commented Sep 3, 2025
edited
Loading

Summary:

There are several changes in ci.yml to ensure proper functioning.

Reasoning:

The Ubuntu 20.04 Actions runner image is now deprecated in github, so those were changed to the Ubuntu 22.04 image. The merge request as well has changes to ensure working pip on Python 2.7.

Having Python 3.6 in CentOS:8 container:

Python 3.6 is not supported on Ubuntu 22 or newer runners. The change adjusts the tests to be run with Python 3.6 in the CentOS:8 container.

Downloading and building git in centOS:6:

Unit tests failed to run due to the error messages, including ImportError and TypeError. Those can be found in action run .
The problem occurred due to an old version of git provided in CentOS 6. To solve the problem, the changes provide the installation of a newer git version.

sergei-lobanov and matejsmycka reacted with thumbs up emoji
Copy link
Member

tomato42 commented Sep 3, 2025

RHEL-8 system python is 3.6... I don't think we can drop support for it...

Copy link
Member

tomato42 commented Sep 3, 2025
edited
Loading

and python 2.6 failures are weird... that stuff should be running on centos 6, ubuntu shouldn't enter the picture...

It worked with 2.6 so it should continue to work, if anything, it's the CI environment that is broken, not the code

Copy link
Contributor Author

gstarovo commented Sep 3, 2025

Okay, thank you, I will investigate Python 2.6 further.

About Python 3.6, the Ubuntu 22 image in GitHub does not support it (and is not planning to, according to this discussion).
Should it then be installed manually (adjust ci.yml to download and install it)?

Copy link
Member

tomato42 commented Sep 3, 2025

I think we can use a RHEL image for it, just as we do for 2.6?

-ensure working pip on python2.7
-adjust python 3.6 to run on centos:8, since ubuntu22 image does not support python3.6
-git version on centos:6 was too old and was not working properly,
changing it to manually download and build newer git version
@tomato42 tomato42 merged commit 55aca78 into tlsfuzzer:master Sep 8, 2025
69 of 70 checks passed
@gstarovo gstarovo deleted the ubuntu20-deprecation branch September 30, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomato42 tomato42 tomato42 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /