Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Updated link to clients in the README #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SmithJohnTaylor wants to merge 1 commit into tldr-pages:master from SmithJohnTaylor:master
Closed

Updated link to clients in the README #51

SmithJohnTaylor wants to merge 1 commit into tldr-pages:master from SmithJohnTaylor:master

Conversation

@SmithJohnTaylor
Copy link

@SmithJohnTaylor SmithJohnTaylor commented Nov 19, 2020

Updated link to additional clients as the clients wiki page was merged into the README.
Fixes #50

@SmithJohnTaylor SmithJohnTaylor changed the title (削除) Updated link to clients in the README (Fixes #50) (削除ここまで) (追記) Updated link to clients in the README (追記ここまで) Nov 19, 2020
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

bl-ue reacted with thumbs up emoji
<p>
There are more clients listed in the
<a href="https://github.com/tldr-pages/tldr/wiki/tldr-clients">tldr clients wiki page</a>.
<a href="https://github.com/tldr-pages/tldr#how-do-i-use-it">tldr README</a>.
Copy link
Member

@waldyrious waldyrious Dec 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wiki page was not actually merged with the README. The page was renamed, though, so the link needs to be updated:

Suggested change
<a href="https://github.com/tldr-pages/tldr#how-do-i-use-it">tldr README</a>.
<a href="https://github.com/tldr-pages/tldr/wiki/tldr-pages-clients">tldr clients wiki page</a>.

Copy link
Member

@waldyrious waldyrious Dec 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SmithJohnTaylor why did you resolve this comment? The link in the diff still points to the README.

Note that the list in the README is not (yet) the most comprehensive source of information about tldr clients. Until the lists are merged into the main README (see #52 for progress on that), I believe it's better to keep this link pointing to the wiki page.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be tldr-pages clients wiki page not (削除) tldr clients wiki page (削除ここまで):

Suggested change
<a href="https://github.com/tldr-pages/tldr#how-do-i-use-it">tldr README</a>.
<a href="https://github.com/tldr-pages/tldr/wiki/tldr-pages-clients">tldr-pages clients wiki page</a>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waldyrious waldyrious waldyrious left review comments

@sbrl sbrl sbrl approved these changes

+1 more reviewer

@bl-ue bl-ue bl-ue left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The site references a clients wiki page that doesn't exist

AltStyle によって変換されたページ (->オリジナル) /