-
-
Notifications
You must be signed in to change notification settings - Fork 42
Update to use Badges for consistency #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@waldyrious any comments ?
@waldyrious any comments ?
Sorry for the delay. I do agree with this change, though. The code is simpler and the visual appearance is more consistent.
I actually would even change the Twitter badge to match the style of the other two, or maybe actually remove it, since the account is not really active anyway. What do you guys think?
What would the resulting style look like ? Who owns this twitter account anyways ?
The current twitter badge is the default style shields.io provides, but we can build a custom badge using an image URL with more parameters. That way the style would be consistent with the other badges.
I'm not sure who the owner of the Twitter account is, but I seem to recall @igorshubovych being one of the people who updated it.
Ok if somebody wants to do it. It's not a big deal for me.
Oh yea that I know. I was just asking in general. New badge looks good 👍
New badge looks good 👍
Agreed, thanks for putting it together @sbrl! Want to open a PR changing the Twitter badge to this one?
Sure! I'll open a PR.
This is just an idea, but I feel it looks a little more consistent and ties in with the main repository badges.
Current:
current look
Updated:
updated look
It also seems a bit odd using an iframe, but maybe it's just me, so feel free to close. 👍