- 
 
 - 
  Notifications
 
You must be signed in to change notification settings  - Fork 42
 
Added tldr-bash-client #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
According to tldr-pages#19 (comment)
@pepa65 sorry about the delay, and thanks again for your efforts 👍
@pepa65 I'm wondering if the wget+chmod approach should be really added here. It's a long command line, and doesn't even make get the script installed globally. Perhaps we should just leave the bpkg version. Savvy users will know to get the script source from the repo (which is linked in the table) and make it accessible system-wide usage. What do you think?
Sure, mentioning wget/chmod is messy, fine if that gets deleted.
Sure, mentioning wget/chmod is messy, fine if that gets deleted. But using a commandline like this would install globally: sudo wget -qO /usr/local/bin/tldr https://raw.githubusercontent.com/pepa65/tldr-bash-client/master/tldr; chmod +x /usr/local/bin/tldr. I didn't want to impose, and it could be possible another client/binary is already installed at that same location...
I'm afraid that's not a good idea, because it would conflict with other clients that install globally that way -- dedicated package managers are more likely have proper mechanisms to detect such a conflict and allow the user to choose how to proceed cleanly.
For example, I have a symbolic link in /usr/local/bin/tldr to a custom shell script I'm working on for tldr, and in several occasions (when I installed another tldr client to test stuff before merging PRs), the shell script ended up overwritten, since the installation process followed the link back to the original file.
In any case, since the command line is even longer than the current one, I'd prefer not having it even if it didn't have this conflict issue. Let me know if this makes sense to you.
I'm fine with the wget line removed. I am agreeing about package managers being the most appropriate mechanism for installing things. When installing from git, that's already different (until these type of installs get supported by package managers, but name space conflicts will arise...)
Ok then. Since you as the author of that line have agreed, I'll go ahead and make the change in a commit directly to master.
Thanks!
According to #19 (comment)