Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added tldr-bash-client #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waldyrious merged 1 commit into tldr-pages:master from pepa65:master
Mar 11, 2017
Merged

Added tldr-bash-client #20

waldyrious merged 1 commit into tldr-pages:master from pepa65:master
Mar 11, 2017

Conversation

@pepa65
Copy link
Contributor

@pepa65 pepa65 commented Mar 3, 2017

According to #19 (comment)

Copy link
Member

@pepa65 sorry about the delay, and thanks again for your efforts 👍

pepa65 reacted with thumbs up emoji

Copy link
Member

@pepa65 I'm wondering if the wget+chmod approach should be really added here. It's a long command line, and doesn't even make get the script installed globally. Perhaps we should just leave the bpkg version. Savvy users will know to get the script source from the repo (which is linked in the table) and make it accessible system-wide usage. What do you think?

Copy link
Contributor Author

pepa65 commented Mar 11, 2017

Sure, mentioning wget/chmod is messy, fine if that gets deleted.

Copy link
Contributor Author

pepa65 commented Mar 12, 2017

Sure, mentioning wget/chmod is messy, fine if that gets deleted. But using a commandline like this would install globally: sudo wget -qO /usr/local/bin/tldr https://raw.githubusercontent.com/pepa65/tldr-bash-client/master/tldr; chmod +x /usr/local/bin/tldr. I didn't want to impose, and it could be possible another client/binary is already installed at that same location...

Copy link
Member

I'm afraid that's not a good idea, because it would conflict with other clients that install globally that way -- dedicated package managers are more likely have proper mechanisms to detect such a conflict and allow the user to choose how to proceed cleanly.

For example, I have a symbolic link in /usr/local/bin/tldr to a custom shell script I'm working on for tldr, and in several occasions (when I installed another tldr client to test stuff before merging PRs), the shell script ended up overwritten, since the installation process followed the link back to the original file.

In any case, since the command line is even longer than the current one, I'd prefer not having it even if it didn't have this conflict issue. Let me know if this makes sense to you.

pepa65 reacted with thumbs up emoji

Copy link
Contributor Author

pepa65 commented Mar 12, 2017

I'm fine with the wget line removed. I am agreeing about package managers being the most appropriate mechanism for installing things. When installing from git, that's already different (until these type of installs get supported by package managers, but name space conflicts will arise...)

Copy link
Member

Ok then. Since you as the author of that line have agreed, I'll go ahead and make the change in a commit directly to master.

pepa65 reacted with thumbs up emoji

Copy link
Contributor Author

pepa65 commented Mar 12, 2017

Thanks!

waldyrious reacted with laugh emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agnivade agnivade agnivade approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /