-
Notifications
You must be signed in to change notification settings - Fork 992
Add testing.T.Context() and testing.B.Context()
#5058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1bd0984 to
4c99a8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems kinda weird that the parent context is not from the parent testing.T, but this seems to be how it is in the Go stdlib.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait, there's specifically a comment on this in the Go stdlib:
There's no reason to inherit this context from parent. The user's code can't observe the difference between the background context and the one from the parent test.
As an alternative, it might be possible to switch to the standard library testing package so we don't need to play catch-up with Go. I've tried it in the past, and I don't think it needs many changes to work. I might look into that later.
Matches https://pkg.go.dev/testing#T.Context and https://pkg.go.dev/testing#B.Context